RELNOTES[INC]: Delete goog.dom.safe.setImageSrc, just assign to `im…

…ageElement.src` directly instead.

We were not able to find any real usage of this API in public GitHub repos:

https://github.com/search?p=27&q=goog.dom.safe+setImageSrc+-mockImageElement+-%22Image+blob+URL%22+-%22Initiate+the+image+request%22+-%22whose+contract+states+that+using%22+-%22No+description+available%22+-goog.net.tmpnetwork+-goog.net.NetworkTester+-goog.dom.safe.assertIsHTMLImageElement_+-goog.net.ChannelRequest+-goog.ui.ServerChart&type=Code

PiperOrigin-RevId: 473686471
Change-Id: Icbf066141c43a334d0f8eaf44993de5170f85e8f

closure/goog/dom/safe.js

@@ -351,33 +351,6 @@ goog.dom.safe.setAnchorHref = function(anchor, url) {
 };
 
 
-/**
- * Safely assigns a URL to an image element's src property.
- *
- * If url is of type goog.html.SafeUrl, its value is unwrapped and assigned to
- * image's src property.  If url is of type string however, it is first
- * sanitized using goog.html.SafeUrl.sanitize.
- *
- * @param {!HTMLImageElement} imageElement The image element whose src property
- *     is to be assigned to.
- * @param {string|!goog.html.SafeUrl} url The URL to assign.
- * @return {void}
- * @see goog.html.SafeUrl#sanitize
- */
-goog.dom.safe.setImageSrc = function(imageElement, url) {
-  'use strict';
-  goog.dom.asserts.assertIsHTMLImageElement(imageElement);
-  /** @type {!goog.html.SafeUrl} */
-  var safeUrl;
-  if (url instanceof goog.html.SafeUrl) {
-    safeUrl = url;
-  } else {
-    var allowDataUrl = /^data:image\//i.test(url);
-    safeUrl = goog.html.SafeUrl.sanitizeAssertUnchanged(url, allowDataUrl);
-  }
-  imageElement.src = goog.html.SafeUrl.unwrap(safeUrl);
-};
-
 /**
  * Safely assigns a URL to a audio element's src property.
  *
@@ -864,11 +837,7 @@ goog.dom.safe.createImageFromBlob = function(blob) {
     'use strict';
     goog.global.URL.revokeObjectURL(objectUrl);
   };
-  goog.dom.safe.setImageSrc(
-      image,
-      goog.html.uncheckedconversions
-          .safeUrlFromStringKnownToSatisfyTypeContract(
-              goog.string.Const.from('Image blob URL.'), objectUrl));
+  image.src = objectUrl;
   return image;
 };
 

closure/goog/dom/safe_test.js

@@ -448,53 +448,6 @@ testSuite({
     assertEquals('javascript:trusted();', element.action);
   },
 
-  testSetImageSrc_withSafeUrlObject() {
-    let mockImageElement = /** @type {!HTMLImageElement} */ ({'src': 'blarg'});
-    withAssertionFailure(() => {
-      safe.setImageSrc(mockImageElement, 'javascript:evil();');
-    });
-    assertEquals('about:invalid#zClosurez', mockImageElement.src);
-
-    mockImageElement = /** @type {!HTMLImageElement} */ ({'src': 'blarg'});
-    const safeUrl = SafeUrl.fromConstant(Const.from('javascript:trusted();'));
-    safe.setImageSrc(mockImageElement, safeUrl);
-    assertEquals('javascript:trusted();', mockImageElement.src);
-
-    // Asserts correct runtime type.
-    if (!userAgent.IE || userAgent.isVersionOrHigher(10)) {
-      const otherElement = document.createElement('SCRIPT');
-      const ex = assertThrows(() => {
-        safe.setImageSrc(
-            /** @type {!HTMLImageElement} */ (otherElement), safeUrl);
-      });
-      assert(googString.contains(
-          ex.message, 'Argument is not a HTMLImageElement'));
-    }
-  },
-
-  testSetImageSrc_withHttpsUrl() {
-    const mockImageElement =
-        /** @type {!HTMLImageElement} */ ({'src': 'blarg'});
-
-    const safeUrl = 'https://trusted_url';
-    safe.setImageSrc(mockImageElement, safeUrl);
-    assertEquals(safeUrl, mockImageElement.src);
-  },
-
-  testSetImageSrc_withDataUrl() {
-    const mockImageElement =
-        /** @type {!HTMLImageElement} */ ({'src': 'blarg'});
-    const safeUrl = 'data:image/gif;base64,a';
-    safe.setImageSrc(mockImageElement, safeUrl);
-    assertEquals(safeUrl, mockImageElement.src);
-    assertThrows(() => {
-      safe.setImageSrc(mockImageElement, 'data:text/plain;base64,a');
-    });
-    assertThrows(() => {
-      safe.setImageSrc(mockImageElement, 'data:image/gif;bad');
-    });
-  },
-
   testSetAudioSrc() {
     let mockAudioElement = /** @type {!HTMLAudioElement} */ ({'src': 'blarg'});
     let safeUrl = 'https://trusted_url';