-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable strict mode for toolbox-search #2055
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Before I give this a review, could you:
- Add the inline comments you deleted back in? The license is especially important to keep for legal reasons!
- Remove the change to
examples/README.md
since that's covered by your other PR?
@BeksOmega made the changes |
Hello @ayan-joshi Looks like a lot of the inline comments are still missing :/ Let me know if you're still interested in working on this now that your competition is over! |
Closing this as stale. If you want to continue working on it feel free to reopen! |
The basics
The details
Resolves
This resolves the issue #2029
Proposed Changes
Added the strict mode for toolbox
Reason for Changes
Asked as the issue for new feature
Additional Information
As mentioned in the issue I enable the strict mode for toolbox search to end with I also searched for the errors and fixed multiple errors in the file have a look and merge it faster if you can please @BeksOmega