Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable strict mode for toolbox-search #2055

Closed
wants to merge 6 commits into from

Conversation

ayan-joshi
Copy link

@ayan-joshi ayan-joshi commented Oct 31, 2023

The basics

The details

Resolves

This resolves the issue #2029

Proposed Changes

Added the strict mode for toolbox

Reason for Changes

Asked as the issue for new feature

Additional Information

As mentioned in the issue I enable the strict mode for toolbox search to end with I also searched for the errors and fixed multiple errors in the file have a look and merge it faster if you can please @BeksOmega

@ayan-joshi ayan-joshi requested a review from a team as a code owner October 31, 2023 17:50
@ayan-joshi ayan-joshi requested review from maribethb and removed request for a team October 31, 2023 17:50
Copy link

google-cla bot commented Oct 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@BeksOmega BeksOmega assigned BeksOmega and unassigned maribethb Oct 31, 2023
@BeksOmega BeksOmega requested review from BeksOmega and removed request for maribethb October 31, 2023 17:50
Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Before I give this a review, could you:

  1. Add the inline comments you deleted back in? The license is especially important to keep for legal reasons!
  2. Remove the change to examples/README.md since that's covered by your other PR?

@ayan-joshi ayan-joshi changed the title Enable strict mode for toolbox-search feat: Enable strict mode for toolbox-search Oct 31, 2023
@ayan-joshi
Copy link
Author

@BeksOmega made the changes

@BeksOmega
Copy link
Contributor

Hello @ayan-joshi Looks like a lot of the inline comments are still missing :/ Let me know if you're still interested in working on this now that your competition is over!

@BeksOmega
Copy link
Contributor

Closing this as stale. If you want to continue working on it feel free to reopen!

@BeksOmega BeksOmega closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants