Fixes #191 #218
Open
Fixes #191 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwlouse
reviewed
Apr 13, 2022
| @@ -737,3 +747,6 @@ def register_object3d_setters(obj, blender_obj): | |||
|
|
|||
| obj.observe(AttributeSetter(blender_obj, "rotation_quaternion"), "quaternion") | |||
| obj.observe(KeyframeSetter(blender_obj, "rotation_quaternion"), "quaternion", type="keyframe") | |||
|
|
|||
| # --- Maps Object3D.cast_shadows to bpy.context.object.cycles_visibility.shadow | |||
| obj.observe(VisibleShadowsSetter(blender_obj), "cast_shadows") | |||
There was a problem hiding this comment.
I think this should work without the need for a dedicated VisibleShadowsSetter:
obj.observe(AttributeSetter(blender_obj.cycles_visibility, "shadow"), "cast_shadows")
Qwlouse
reviewed
Apr 13, 2022
| up = tl.CaselessStrEnum(["X", "Y", "Z", "-X", "-Y", "-Z"], default_value="Y") | ||
| front = tl.CaselessStrEnum(["X", "Y", "Z", "-X", "-Y", "-Z"], default_value="-Z") | ||
| cast_shadows = tl.Bool(default_value=True) |
There was a problem hiding this comment.
I think PhysicalObject would be a better place for this property, since all cameras and lights also inherit from Object3D, and I am reasonably sure that cast_shadow will either not work on those or not behave as expected.
Qwlouse
requested changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.