fix: notifications panel #5786
Merged
fix: notifications panel #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandl
added
ready to review
|
extended-test --record |
|
"extended-test --record" started. Check the progress here. |
|
❌ "extended-test --record" finished with result failure. Check the results here. |
|
extended-test --record |
|
"extended-test --record" started. Check the progress here. |
|
✅ "extended-test --record" finished with result success. Check the results here. |
kandl
force-pushed
the
mkn-f1-1020-fix
branch
from
0888ae2 to
d5ce873
Compare
risk: low JIRA: F1-1019
Design fixes. Display notification errors. Remove `useNotifications` hook from docs and public API for now. risk: low JIRA: F1-1020
kandl
force-pushed
the
mkn-f1-1020-fix
branch
from
d5ce873 to
5bb923f
Compare
scavnickyj
reviewed
Jan 13, 2025
libs/sdk-ui-ext/src/notificationsPanel/Notification/AlertNotification.tsx
Show resolved
Hide resolved
scavnickyj
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design fixes.
Display notification errors.
Remove
useNotificationshook from docs and public API for now.Enable in-platform notifications FF by default.
risk: low
JIRA: F1-1020
Important
Please, don't forget to run
rush changefor the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.Run extended test by pull request comment
Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.
Explanation
--backstopThe command to run screen tests.--integratedThe command to run integrated tests against the live backend.--isolatedThe command to run isolated tests against recordings.--recordThe command to create new recordings for isolated tests.--filter(Optional) A comma-separated list of test files to run. This parameter is valid only for the--integrated,--isolated, and--recordcommands.Examples