Handle undefined in a returned array. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
force-pushed
the
issue_30_undef_in_eval_returned_array
branch
2 times, most recently
from
ced61fd to
dc0110d
Compare
FGasper
force-pushed
the
issue_30_undef_in_eval_returned_array
branch
from
dc0110d to
76bd2e3
Compare
Issue gonzus#30: Missing JS array items cause Duktape’s duk_get_prop_index() to return false. In that case pl_duk_to_perl_impl() was neglecting to duk_pop(ctx), which caused the next read on the array to be an attempt to read index 1 from undefined, which triggered an abort(). This fixes that by ensuring that we always duk_pop(ctx) in the relevant piece of code and return Perl undef to represent missing array items.
FGasper
force-pushed
the
issue_30_undef_in_eval_returned_array
branch
from
76bd2e3 to
1ac30c3
Compare
|
Merged more or less blindly -- let me know if anything broke. Thanks! |
|
Can this be closed? |
|
@gflohr I think the merge of the PR constitutes a “close” of the request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #30: JS “undefined” causes Duktape’s duk_get_prop_index()
to return false, even though the value does exist. (This is an
apparent bug either in Duktape or its documentation, which suggests
that any existent property should cause a truthy return from that
function.) In that case pl_duk_to_perl_impl() was neglecting to
duk_pop(ctx), which caused the next read on the array to be an attempt
to read index 1 from undefined, which triggered an abort().
This fixes that by ensuring that we always duk_pop(ctx) in the relevant
piece of code.