SIGABRT when reading nonexistent array members #30

FGasper · 2021-11-17T03:33:15Z

#!perl

use strict;
use warnings;

use FindBin;
use blib;

use JavaScript::Duktape::XS;

my $js = JavaScript::Duktape::XS->new();

$js->eval(
    qq<
        var croaker = function() { throw "hahaha" };
        var got = [];
        try {
            croaker();
        }
        catch(e) {
            got[1] = e;
        }

        got
    >
);

… yields SIGABRT, with the following output:

duktape fatal error, aborting: uncaught: 'cannot read property 1 of undefined'

The text was updated successfully, but these errors were encountered:

Issue gonzus#30: JS “undefined” causes Duktape’s duk_get_prop_index() to return false, even though the value *does* exist. (This is an apparent bug either in Duktape or its documentation, which suggests that any existent property should cause a truthy return from that function.) In that case pl_duk_to_perl_impl() was neglecting to duk_pop(ctx), which caused the next read on the array to be an attempt to read index 1 from undefined, which triggered an abort(). This fixes that by ensuring that we always duk_pop(ctx) in the relevant piece of code.

Issue gonzus#30: Missing JS array items cause Duktape’s duk_get_prop_index() to return false. In that case pl_duk_to_perl_impl() was neglecting to duk_pop(ctx), which caused the next read on the array to be an attempt to read index 1 from undefined, which triggered an abort(). This fixes that by ensuring that we always duk_pop(ctx) in the relevant piece of code and return Perl undef to represent missing array items.

FGasper mentioned this issue Nov 17, 2021

Handle undefined in a returned array. #31

Merged

FGasper changed the title ~~SIGABRT on try/catch~~ SIGABRT when reading nonexistent array members Nov 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SIGABRT when reading nonexistent array members #30

SIGABRT when reading nonexistent array members #30

FGasper commented Nov 17, 2021

SIGABRT when reading nonexistent array members #30

SIGABRT when reading nonexistent array members #30

Comments

FGasper commented Nov 17, 2021