Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Thingy:91 sensors #17

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Abstract Thingy:91 sensors #17

merged 2 commits into from
Dec 18, 2024

Conversation

szczys
Copy link
Collaborator

@szczys szczys commented Dec 16, 2024

  • Move buzzer code to its own file
  • Conditionally build buzzer code based on board
  • Move sensors to their own functions
  • Use CBOR when sending data to Golioth

Resolves https://github.com/golioth/devrel-issue-tracker/issues/507

Add app_buzzer.c/h and move buzzer-related code there. This file will
always be built, but functions will only be included for original Thingy:91
(the thingy91 has a buzzer, thingy91x does not).

Signed-off-by: Mike Szczys <[email protected]>
- Breakout each sensor reading into its own function
- Use CBOR to encode the data sent to Golioth
- Update Pipeline example to use CBOR

Signed-off-by: Mike Szczys <[email protected]>
@szczys szczys force-pushed the szczys/abstract-thingy91-sensors branch from 9ca7f42 to fe6b439 Compare December 16, 2024 21:33
Copy link
Contributor

@MarkoPura MarkoPura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from merge/template_v2.5.0 to main December 18, 2024 16:46
@szczys szczys merged commit 889e12f into main Dec 18, 2024
1 check passed
@szczys szczys deleted the szczys/abstract-thingy91-sensors branch December 18, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants