This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
gitlab-ci: drop gitlint and use generalize by using environment variables #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitlint is already part of Docker image, so there is no need to install it manually. Signed-off-by: Marcin Niestroj <[email protected]>
There is already $CI_DEFAULT_BRANCH provided by GitLab CI, so use it instead of hardcoded 'main'. Introduce global $MODULE_PATH, so that 'modules/lib/golioth' does not need to be hardcoded in multiple places. Signed-off-by: Marcin Niestroj <[email protected]>
|
Visit the preview URL for this PR (updated for commit 5b874f0): https://golioth-zephyr-sdk-doxygen-dev--pr436-gitlab-ci-improv-lxnshk9x.web.app (expires Tue, 17 Oct 2023 12:27:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a389eefadf4b4b68a539327b3459dd66c142cf49 |
sam-golioth
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitlint is already part of Docker image, so there is no need to install it
manually.
There is already
$CI_DEFAULT_BRANCHprovided by GitLab CI, so use itinstead of hardcoded
main.Introduce global
$MODULE_PATH, so thatmodules/lib/goliothdoes notneed to be hardcoded in multiple places.