Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

net: enable extended master secret #432

Merged
merged 1 commit into from
Oct 11, 2023
Merged

net: enable extended master secret #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions net/golioth/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ config GOLIOTH
select MBEDTLS_DTLS if MBEDTLS_BUILTIN
select MBEDTLS_TLS_LIBRARY if NRF_SECURITY
select MBEDTLS_SSL_PROTO_DTLS if NRF_SECURITY
select MBEDTLS_SSL_EXTENDED_MASTER_SECRET
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far we have all the required features pointed out here with select ... statement. MBEDTLS_SSL_EXTENDED_MASTER_SECRET is not required. So we should either:

  • make it explicit in commit message why it is required from now on (e.g. by wanting to change Golioth backend policy and make it a requirement at some point),
  • use imply ... instead of select ... to allow customers to disable it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the commit message to indicate that Golioth may enforce the use of Extended Master Secret on the server side in the future.

select NET_SOCKETS
select NET_UDP
imply DNS_RESOLVER if NET_NATIVE
Expand Down
Loading