-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location WiFi - twister+pytest test for native_sim and playback data #725
Conversation
Visit the preview URL for this PR (updated for commit 0eee67f): https://golioth-firmware-sdk-doxygen-dev--pr725-location-wifi-w93yako9.web.app (expires Sat, 18 Jan 2025 06:15:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
We get:
due to prod not supporting location yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @mniestroj! The failures in prod will be annoying but I think we should still merge this in.
d03965f
to
0eee67f
Compare
Rely on playback data to result in accurate location data. Wait for first 5 locations and match logged data with expected position. Signed-off-by: Marcin Niestroj <[email protected]>
0eee67f
to
822fc1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! I thought I hit approve last week.
Merging this PR is in conflict with our strategy to increase number of "required" tests. Additionally there is already a test that prevents merging this PR: Event if we would temporarily disable checks, then still all upcoming PRs will be blocked as that test won't pass. So we need to either wait for backend location service or disable native_sim tests as being required. The major benefit of having tests merged and running in the CI is to get feedback whenever something breaks... this won't be the case if we merge this one. It is great that we have the test already developed, but I don't think we gain anything by trying to merge early. So I propose to just wait and rebase once we are ready on the backend side. |
That's a great point. I'm good with waiting for the backend support 👍 |
Closing in favor of #730, which has combined cellular and wifi tests. |
No description provided.