-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
location: cellular: initial support with example application #717
Open
mniestroj
wants to merge
4
commits into
main
Choose a base branch
from
location-cellular
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 81a7cc0): https://golioth-firmware-sdk-doxygen-dev--pr717-location-cellu-sknxiq39.web.app (expires Sat, 18 Jan 2025 06:19:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Codecov ReportAttention: Patch coverage is
|
mniestroj
force-pushed
the
location-cellular
branch
3 times, most recently
from
January 2, 2025 15:23
ac49c15
to
0cebadd
Compare
mniestroj
force-pushed
the
location-wifi
branch
5 times, most recently
from
January 9, 2025 13:26
ccc2394
to
1f49b15
Compare
mniestroj
force-pushed
the
location-cellular
branch
3 times, most recently
from
January 9, 2025 15:54
19415cc
to
e7e4da3
Compare
mniestroj
force-pushed
the
location-wifi
branch
from
January 10, 2025 15:21
1f49b15
to
a0996d7
Compare
mniestroj
requested review from
sam-golioth and
szczys
and removed request for
sam-golioth
January 11, 2025 06:16
Introduce support for Golioth cellular location service. Signed-off-by: Marcin Niestroj <[email protected]>
Add a sample with cellular network cell towers collected over the city trip. This is a playback with configurable speed (1x by default) to quickly see results over time during testing (e.g. on a Grafana map plugin). Signed-off-by: Marcin Niestroj <[email protected]>
Add nRF91 specific cellular tower information fetching and use when requesting location data. Use current cell only for now, as that is the only information provided with the tested modem and SIM card. Leave logs for neighbour cells enabled, so that extending this sample in the future is easy. Signed-off-by: Marcin Niestroj <[email protected]>
Signed-off-by: Marcin Niestroj <[email protected]>
mniestroj
force-pushed
the
location-cellular
branch
from
January 11, 2025 06:17
e7e4da3
to
81a7cc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.