ci: split lint and unit_tests #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 40f9aeb): https://golioth-firmware-sdk-doxygen-dev--pr628-split-list-uni-djh7twe3.web.app (expires Tue, 08 Oct 2024 06:18:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
mniestroj
force-pushed
the
split-list-unit-tests
branch
2 times, most recently
from
21b21e1 to
7b765da
Compare
Code Coverage (Linux)
|
Code Coverage (Zephyr)
|
mniestroj
force-pushed
the
split-list-unit-tests
branch
from
7b765da to
282f5ba
Compare
sam-golioth
approved these changes
Sep 26, 2024
| - name: Checkout repository and submodules | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: 'recursive' |
There was a problem hiding this comment.
I think we can avoid checking out submodules for the lint step.
mniestroj
force-pushed
the
split-list-unit-tests
branch
from
282f5ba to
521fbe2
Compare
szczys
approved these changes
Sep 26, 2024
mniestroj
force-pushed
the
split-list-unit-tests
branch
3 times, most recently
from
91ec388 to
21c56c6
Compare
Both are not related to each other and they should be split into separate jobs. Signed-off-by: Marcin Niestroj <[email protected]>
mniestroj
force-pushed
the
split-list-unit-tests
branch
from
21c56c6 to
40f9aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both are not related to each other and they should be split into separate
jobs.