Stop client before destroying #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When purge_request_mbox() it was conditionally freeing POST quests but should also check for POST_BLOCK requests which have a dynamically allocated payload. Signed-off-by: Mike Szczys <[email protected]>
If the client is running when golioth_client_destroy() is called it needs to be stopped before freeing the client. When the client is stopped, the logging backend will be disabled, preventing log messages from trying to access the client after it is freed. The linked list of requests (client->coap_reqs) will then also be freed as part of the stop process, ensuring there isn't any allocated OBSERVE or POST/POST_BLOCK memory leaked. Signed-off-by: Mike Szczys <[email protected]>
szczys
requested review from
mniestroj and
sam-golioth
and removed request for
mniestroj and
sam-golioth
|
Visit the preview URL for this PR (updated for commit 94fc673): https://golioth-firmware-sdk-doxygen-dev--pr547-szczys-fix-cli-fte3fpvq.web.app (expires Wed, 07 Aug 2024 14:56:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Code Coverage
|
When purge_request_mbox() it was conditionally freeing POST quests but should also check for POST_BLOCK requests which have a dynamically allocated payload. Signed-off-by: Mike Szczys <[email protected]>
Automatic formatting was applied to this file, no substantive changes were made to the code. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/fix_client_destroy
branch
from
63669b9 to
a0a7bf5
Compare
This prevents attempts to send logs messages to the cloud when the client is disconnected. Upon reconnect, backend logging will be enabled based on CONFIG_GOLIOTH_AUTO_LOG_TO_CLOUD. Signed-off-by: Mike Szczys <[email protected]>
If the client is running when golioth_client_destroy() is called it needs to be stopped before freeing the client. When the client is stopped, golioth_sys_client_disconnected() is now called which in turn sets golioth_debug_set_cloud_log_enabled() to false. This prevents attempts to send log messages to Golioth when the client is not connected. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/fix_client_destroy
branch
from
e7e2dcc to
63d2136
Compare
szczys
force-pushed
the
szczys/fix_client_destroy
branch
from
63d2136 to
845f68e
Compare
- Add golioth_client_destroy() and subsequent reconnect to test ability to destroy and restart the client - Add a semaphore to block until each new connection is established. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/fix_client_destroy
branch
from
845f68e to
94fc673
Compare
sam-golioth
approved these changes
Jul 31, 2024
| @@ -14,38 +14,45 @@ | |||
| * Time | |||
| *------------------------------------------------*/ | |||
|
|
|||
| uint64_t golioth_sys_now_ms() { | |||
| uint64_t golioth_sys_now_ms() | |||
There was a problem hiding this comment.
These are moving from the FreeRTOS port to the system ports (ESP-IDF, ModusToolBox, etc.) in #486, but I think it's fine to keep it here for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/golioth/firmware-issue-tracker/issues/584