Update from training feedback #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following user feedback, the admonition about plugging in and turning on the board is now it's own numbered bullet point. Signed-off-by: Mike Szczys <[email protected]>
To avoid user confusion, remove the <> around settings values. Instead wrap them all in "" so that spaces and extended characters are handles gracefully. Signed-off-by: Mike Szczys <[email protected]>
- Place tabs around build commands so only the command relevant to a chosen board is shown. - Remove in-code comment about board name so command may be copied more easily. Signed-off-by: Mike Szczys <[email protected]>
Nordic change the URL format for their documentation and old links do not redirect. Signed-off-by: Mike Szczys <[email protected]>
Explain how dashes in devicetree are converted to underscores in C code. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/update-from-training-feedback
branch
from
d127966 to
ffce851
Compare
|
Visit the preview URL for this PR (updated for commit ffce851): https://golioth-training--pr100-szczys-update-from-t-iqtzv8bz.web.app (expires Thu, 19 Dec 2024 22:09:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c5dc029ca233830e70690d9f5440a110931e16d2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/golioth/devrel-issue-tracker/issues/500