term: remove duplicate flag and add comment on windows #14

aymanbagabas · 2024-02-09T17:24:50Z

Both windows.ENABLE_PROCESSED_INPUT and windows.ENABLE_PROCESSED_OUTPUT have the same value of 0x1. Using makeRaw on a console output screen buffer handle wouldn't make sense since on Windows the input handle and the output screen buffer handle are two separate things.

See https://learn.microsoft.com/en-us/windows/console/setconsolemode

Both `windows.ENABLE_PROCESSED_INPUT` and `windows.ENABLE_PROCESSED_OUTPUT` have the same value of `0x1`. Using `makeRaw` on a console output screen buffer handle wouldn't make sense since on Windows the input handle and the output screen buffer handle are two separate things. See https://learn.microsoft.com/en-us/windows/console/setconsolemode

gopherbot · 2024-02-09T17:35:46Z

This PR (HEAD: 43baa50) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/562779.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-09T17:42:13Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)