Mark locale
feature as experimental
#1892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
locale
feature was requested in #323, and while it was implemented to a reasonable degree in #1818, I still have some slight concerns about it:collate
library increases the size of the compiled binary from around 4MB to 5.6MB (an increase of 40%). This concern has been raised in File size of `lf` executable increased #1836.In any case, unless there are issues raised from other users, I think it is unlikely that I will make any changes to the
locale
feature in future. However I am still marking it as experimental just in case.