Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark locale feature as experimental #1892

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

joelim-work
Copy link
Collaborator

The locale feature was requested in #323, and while it was implemented to a reasonable degree in #1818, I still have some slight concerns about it:

  • The feature was developed with mainly sorting Chinese text in mind, however there are many other languages in existence and there is little to no testing for those.
  • The addition of the collate library increases the size of the compiled binary from around 4MB to 5.6MB (an increase of 40%). This concern has been raised in File size of `lf` executable increased #1836.
  • There is a possibility that locale-aware sorting could be lumped with all the other custom sorting requests as part of Sort by custom method #618, making the current implementation redundant.

In any case, unless there are issues raised from other users, I think it is unlikely that I will make any changes to the locale feature in future. However I am still marking it as experimental just in case.

@joelim-work joelim-work merged commit 2375b65 into gokcehan:master Jan 15, 2025
4 checks passed
@joelim-work joelim-work deleted the locale-experimental branch January 15, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant