Taking hidden files parameter into account in windows

[Catalyn45]

fixes: #1683

On windows a file is considered hidden only if it has FILE_ATTRIBUTE_HIDDEN set. While this is the correct way to check if a file is hidden on windows, we should also take into account the hiddenfiles option so we can allow custom file patterns (ex. __pycache__, obj) as we can do on Linux.

[joelim-work]

Thanks for the PR. The code itself looks OK, but could you please do the following:

• Update the documentation for the hidden option.
• Check if the following linter comment is still relevant:

  lf/nav.go

  Lines 754 to 755 in ce12116

  	//lint:ignore U1000 This function is not used on Windows
  	func matchPattern(pattern, name, path string) bool {

[joelim-work]

Looks good, thanks once again for the changes.

[gokcehan]

Thank you @Catalyn45 for the patch and @joelim-work for the review. I like the idea of enabling the use of hiddenfiles on Windows, but is it a good idea to hide dot files by default on Windows? Perhaps the default for hiddenfiles should be .* on unix and empty on Windows. What do you think?

[Catalyn45]

I don't think we have other options that have a different default value depending on the os right? Maybe making this the only one will be a bit inconsistent and misleading.

Maybe a better alternative would be to put set hiddenfiles "" in the lf.ps1.example and lf.cmd.example.

Alternatively we can create some init_os_options at the end of options initialization.

[gokcehan]

@Catalyn45 Actually, we have shell and shellflag options with different values on Unix and Windows. Also, ifs option only works on Unix and not Windows. Unfortunately, I think the inconsistency is inherent in this case as there is no equivalent of hidden attributes on Unix. Nevertheless, I guess I don't have much of a strong opinion about this either way, so feel free to decide by yourself.

[joelim-work]

Ah, I did not consider the default value of hiddenfiles at all.

In that case, yes I agree with @gokcehan that this should be handled similarly to shell and shellflag (i.e. add definitions for gDefaultHiddenFiles in os.go and os_windows.go). The documentation also specifies the default values for each option, so that should be updated too.

[Catalyn45]

Applied the suggestion, tell me if there is something else I should change.