gofumpt lint and misc cleanup #1682
Conversation
| @@ -326,7 +326,7 @@ func TestGetFileExtension(t *testing.T) { | |||
| for _, test := range tests { | |||
| t.Run(test.name, func(t *testing.T) { | |||
| if got := getFileExtension(fakeFileInfo{test.fileName, test.isDir}); got != test.expectedExtension { | |||
| t.Errorf("at input %q expected %q but got %q", test.fileName, test.expectedExtension, got) | |||
| t.Errorf("at input '%s' expected '%s' but got '%s'", test.fileName, test.expectedExtension, got) | |||
There was a problem hiding this comment.
%q quotes strings with double quotes, so changing to '%s' to match output of other tests
| @@ -471,7 +471,7 @@ func (win *win) printDir(ui *ui, dir *dir, context *dirContext, dirStyle *dirSty | |||
| filename = append(filename, []rune(gOpts.truncatechar)...) | |||
| filename = append(filename, lastPart...) | |||
| } | |||
| for i := runeSliceWidth(filename); i < maxFilenameWidth; i++ { | |||
| for j := runeSliceWidth(filename); j < maxFilenameWidth; j++ { | |||
There was a problem hiding this comment.
i is used in parent for, so this shadowed it
There was a problem hiding this comment.
Thanks for the cleanup.
Going forward I'm not sure how to enforce the use of gofumpt, or whether it is necessary at all. On one hand it is nice to have stricter linting, but on the other hand it is extra effort to setup for contributors. Unless you are happy to submit this kind of PR once in a while.
We could run it in a pipeline, but I think just seeing this as a one-off cleanup is fine. I did this to fix the inconsistencies caused by my previous MR, mostly with octal integers, like |
This runs the gofumpt linter over the code base and then some additional manual cleanups