Refactor eval code #1591
Merged
Refactor eval code #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turns out position and loadfile are required here too since the list of files can change (similar to hidden option)
|
Looks good to me, closing my PR |
|
I haven't looked this over carefully, but it certainly looks like an improvement. Nice! :) |
gokcehan
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1569 (comment), I have decided to submit this as an alternative to #1569.
In my opinion, converting the
switchstatement into amap[string]funcadds significant overhead (as well as an extra layer of indirection), and the main focus should be to deduplicate the logic for evaluating thesetExprobject. I have also applied the same change tosetLocalExpras well. Regardingcomplete.go, I think it is better to leave it for a separate PR.@gokcehan, @Michael-Gallo Please let me know what you think.