Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed errors for compiling with Java17, gradle 8.1, godot 4.3 + Update payments plugin from v5.2.1 to v7.0.0 #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

itslenny
Copy link

@itslenny itslenny commented Dec 25, 2024

This PR is a merge of #64 and #67.

This allows building using Java 17, Gradle 8.1, Google Play Billing 7.0.0, and Godot 4.3 which can successfully build and be submitted to Google Play without it complaining about the outdated Google Play Billing.

I plan to test this extensively over the course of the next week, but would love some other eyes on it as well.

@itslenny itslenny changed the title Fixed errors for compiling with Java17, gradle 8.1, godot 4.2.2 + Update from v5.2.1 to v7.0.0 Fixed errors for compiling with Java17, gradle 8.1, godot 4.3 + Update from v5.2.1 to v7.0.0 Dec 25, 2024
@itslenny itslenny changed the title Fixed errors for compiling with Java17, gradle 8.1, godot 4.3 + Update from v5.2.1 to v7.0.0 Fixed errors for compiling with Java17, gradle 8.1, godot 4.3 + Update payments plugin from v5.2.1 to v7.0.0 Dec 25, 2024
@AndreCartuner
Copy link

Hey there, just in case this is still being developed; I've tried your pull req and i get some errors, first of all it breaks 2D physics engines like rapier and box2D for some reason.
Next up is that it doesn't let me build despite having the requirements (java 17 etc)
If you want to look it up i'm up for it if you need proof etc

platform/windows/os_windows.cpp:383 - Condition "!FileAccess::exists(path)" is true. Returning: ERR_FILE_NOT_FOUND
This is the first error that than follows 100s of related ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants