time out bad plugins fixes #513

gobuffalo · Jul 16, 2017 · 0891ea6 · 0891ea6
1 parent cba8924
commit 0891ea6
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/plugins/plugins.go b/plugins/plugins.go
@@ -2,13 +2,15 @@ package plugins
 
 import (
 	"bytes"
+	"context"
 	"encoding/json"
 	"fmt"
 	"os"
 	"os/exec"
 	"path/filepath"
 	"runtime"
 	"strings"
+	"time"
 
 	"github.com/pkg/errors"
 
@@ -80,7 +82,9 @@ func Available() (List, error) {
 
 func askBin(path string, ch chan Command) error {
 	commands := Commands{}
-	cmd := exec.Command(path, "available")
+	ctx, cancel := context.WithTimeout(context.Background(), time.Second)
+	defer cancel()
+	cmd := exec.CommandContext(ctx, path, "available")
 	bb := &bytes.Buffer{}
 	cmd.Stdout = bb
 	cmd.Stderr = bb