Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing]DutyPusher #5383

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Testing]DutyPusher #5383

wants to merge 6 commits into from

Conversation

MorCherlf
Copy link

DutyPusher could send a notification to the mobile device (for now, it's works only on the iOS/iPadOS) when your duty has been found.
The notification works on the Bark or Pushdeer.
For now, the plugin supports the English/Japanese/Chinese game client, and display in English/Chinese.
The introduction and guide of the plugin is here.

@bleatbot bleatbot enabled auto-merge (squash) January 24, 2025 12:53
@reiichi001
Copy link
Contributor

Hello! While we don't have any strict rules on plugins with duplicate feature sets, would you perhaps be interested in adding these notifications services to an existing plugin that handles similar already?

https://github.com/lostkagamine/PushyFinder currently provides support for Pushover, NFTY, and Discord. It likely could be extended to include your implementations for Bark and Pushdeer.

@reiichi001
Copy link
Contributor

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Jan 24, 2025

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 5 hours.

Name Commit Status
DutyPusher [testing-live] 8749ae0 Build failed (Diff)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Dalamud.Loc 1.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Jan 24, 2025
auto-merge was automatically disabled January 25, 2025 07:07

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Jan 25, 2025

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
DutyPusher [testing-live] 0eeb15b Build failed (Diff)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Dalamud.Loc 1.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Jan 25, 2025

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
DutyPusher [testing-live] 2e963d3 Build failed (Diff)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Dalamud.Loc 1.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Jan 25, 2025

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ DutyPusher [testing-live] 90e492f v0.1.1.0 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Dalamud.Loc 1.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Jan 25, 2025
@bleatbot
Copy link
Collaborator

bleatbot commented Jan 30, 2025

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ DutyPusher [testing-live] 6ddc04d v0.1.2.0 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Dalamud.Loc 1.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@philpax philpax added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Feb 3, 2025
@philpax
Copy link
Contributor

philpax commented Feb 3, 2025

Apologies for the delay - this plugin is now in the plugin review queue; we hope to get back to you soon!

I echo @reiichi001's sentiment that this overlaps with PushyFinder, and that we gently encourage you to add Bark or Pushdeer support to PF instead. We will still take this plugin through the process, but our recommendation would be to merge.

@bleatbot
Copy link
Collaborator

bleatbot commented Feb 6, 2025

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ DutyPusher [testing-live] 97e4c5a v0.1.2.0 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Dalamud.Loc 1.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot removed pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants