Migrate to the nikic/php-parser: ^5.0

composer.json

@@ -23,12 +23,13 @@
   },
   "require": {
     "php": ">=8.2",
-    "nikic/php-parser": "^4.0"
+    "nikic/php-parser": "^5.0"
   },
   "require-dev": {
     "phpunit/phpunit": "^10.5.8",
     "tracy/tracy": "^2.10",
-    "rector/rector": "^1.0"
+    "rector/rector": "^1.0",
+    "rector/rector-php-parser": "^0.14.0"
   },
   "extra": {
     "branch-alias": {

rector.php

@@ -7,6 +7,7 @@
 use Rector\DeadCode\Rector\ClassMethod\RemoveUselessReturnTagRector;
 use Rector\Php71\Rector\ClassConst\PublicConstantVisibilityRector;
 use Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector;
+use Rector\PhpParser\Set\PhpParserSetList;
 use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector;
 
@@ -27,4 +28,5 @@
     ->withSets([
         PHPUnitSetList::ANNOTATIONS_TO_ATTRIBUTES,
         PHPUnitSetList::PHPUNIT_CODE_QUALITY,
+        PhpParserSetList::PHP_PARSER_50
     ]);

src/NodeVisitor/GeneratorDetector.php

@@ -13,7 +13,6 @@
 namespace Go\ParserReflection\NodeVisitor;
 
 use PhpParser\Node;
-use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 
 /**
@@ -30,7 +29,7 @@ public function enterNode(Node $node)
     {
         // There may be internal generators in closures, we do not need to look at them
         if ($node instanceof Node\Expr\Closure) {
-            return NodeTraverser::DONT_TRAVERSE_CHILDREN;
+            return self::DONT_TRAVERSE_CHILDREN;
         }
 
         if ($node instanceof Node\Expr\Yield_ || $node instanceof Node\Expr\YieldFrom) {

src/NodeVisitor/StaticVariablesCollector.php

@@ -14,7 +14,6 @@
 
 use Go\ParserReflection\ValueResolver\NodeExpressionResolver;
 use PhpParser\Node;
-use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 
 /**
@@ -48,7 +47,7 @@ public function enterNode(Node $node)
     {
         // There may be internal closures, we do not need to look at them
         if ($node instanceof Node\Expr\Closure) {
-            return NodeTraverser::DONT_TRAVERSE_CHILDREN;
+            return self::DONT_TRAVERSE_CHILDREN;
         }
 
         if ($node instanceof Node\Stmt\Static_) {

src/ReflectionAttribute.php

@@ -13,15 +13,15 @@
 namespace Go\ParserReflection;
 
 use Go\ParserReflection\ValueResolver\NodeExpressionResolver;
-use ReflectionAttribute as BaseReflectionAttribute;
 use PhpParser\Node;
 use PhpParser\Node\Param;
+use PhpParser\Node\PropertyItem;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassConst;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\Node\Stmt\Property;
-use PhpParser\Node\Stmt\PropertyProperty;
+use ReflectionAttribute as BaseReflectionAttribute;
 
 /**
  * ref original usage https://3v4l.org/duaQI
@@ -38,11 +38,11 @@ public function __construct(
 
     public function getNode(): Node\Attribute
     {
-        /** @var Class_|ClassMethod|PropertyProperty|ClassConst|Function_|Param $node  */
+        /** @var Class_|ClassMethod|PropertyItem|ClassConst|Function_|Param $node  */
         $node = $this->reflector->getNode();
 
         // attrGroups only exists in Property Stmt
-        if ($node instanceof PropertyProperty) {
+        if ($node instanceof PropertyItem) {
             $node = $this->reflector->getTypeNode();
         }
 

src/ReflectionEngine.php

@@ -56,26 +56,11 @@ class ReflectionEngine
      */
     protected static $traverser;
 
-    /**
-     * @var null|Lexer
-     */
-    protected static $lexer;
-
     private function __construct() {}
 
     public static function init(LocatorInterface $locator): void
     {
-        self::$lexer = new Lexer(['usedAttributes' => [
-            'comments',
-            'startLine',
-            'endLine',
-            'startTokenPos',
-            'endTokenPos',
-            'startFilePos',
-            'endFilePos'
-        ]]);
-
-        self::$parser = (new ParserFactory())->create(ParserFactory::PREFER_PHP7, self::$lexer);
+        self::$parser = (new ParserFactory())->createForHostVersion();
 
         self::$traverser = $traverser = new NodeTraverser();
         $traverser->addVisitor(new NameResolver());
@@ -191,7 +176,7 @@ public static function parseClassMethod(string $fullClassName, string $methodNam
     /**
      * Parses class property
      *
-     * @return array Pair of [Property and PropertyProperty] nodes
+     * @return array Pair of [Property and PropertyItem] nodes
      */
     public static function parseClassProperty(string $fullClassName, string $propertyName): array
     {
@@ -284,12 +269,4 @@ public static function parseFileNamespace(string $fileName, string $namespaceNam
 
         throw new ReflectionException("Namespace $namespaceName was not found in the file $fileName");
     }
-
-    /**
-     * @return Lexer
-     */
-    public static function getLexer(): ?Lexer
-    {
-        return self::$lexer;
-    }
 }

src/ReflectionFile.php

@@ -128,7 +128,7 @@ public function isStrictMode(): bool
 
         $declareStatement = reset($topLevelNode->declares);
         $isStrictTypeKey  = $declareStatement->key->toString() === 'strict_types';
-        $isScalarValue    = $declareStatement->value instanceof Node\Scalar\LNumber;
+        $isScalarValue    = $declareStatement->value instanceof Node\Scalar\Int_;
         $isStrictMode     = $isStrictTypeKey && $isScalarValue && $declareStatement->value->value === 1;
 
         return $isStrictMode;

src/ReflectionProperty.php

@@ -15,9 +15,9 @@
 use Go\ParserReflection\Traits\InitializationTrait;
 use Go\ParserReflection\Traits\InternalPropertiesEmulationTrait;
 use Go\ParserReflection\ValueResolver\NodeExpressionResolver;
+use PhpParser\Node\PropertyItem;
 use PhpParser\Node\Stmt\ClassLike;
 use PhpParser\Node\Stmt\Property;
-use PhpParser\Node\Stmt\PropertyProperty;
 use Reflection;
 use ReflectionProperty as BaseReflectionProperty;
 
@@ -41,7 +41,7 @@ class ReflectionProperty extends BaseReflectionProperty
     /**
      * Concrete property node
      *
-     * @var PropertyProperty
+     * @var PropertyItem
      */
     private $propertyNode;
 
@@ -58,13 +58,13 @@ class ReflectionProperty extends BaseReflectionProperty
      * @param string            $className    Name of the class with properties
      * @param string            $propertyName Name of the property to reflect
      * @param ?Property         $propertyType Property type definition node
-     * @param ?PropertyProperty $propertyNode Concrete property definition (value, name)
+     * @param ?PropertyItem     $propertyNode Concrete property definition (value, name)
      */
     public function __construct(
         $className,
         $propertyName,
         Property $propertyType = null,
-        PropertyProperty $propertyNode = null
+        PropertyItem $propertyNode = null
     ) {
         $this->className = ltrim($className, '\\');
         if (!$propertyType || !$propertyNode) {
@@ -81,7 +81,7 @@ public function __construct(
     /**
      * Returns an AST-node for property
      *
-     * @return PropertyProperty
+     * @return PropertyItem
      */
     public function getNode()
     {