feat: cdp.Client impl Contextable interface #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the Contextable interface for cdp.Client, preparing to introduce *goob.Observable: - Add a ctx field in the Client struct to store the context of the current instance. - Add a GetContext method to retrieve the context of the current instance. - Add a Context method to create a copy of the client with a specified context. - Update the New method to set a default context for newly created client instances. - Modify the test files and utils.go to support the new context management functionality.
- Due to clone use pointer - Change pending from sync.Map to *sync.Map- This modification ensures proper memory management and prevents potential memory leaks
ysmood
requested changes
Dec 21, 2024
| @@ -48,7 +48,9 @@ type Client struct { | |||
|
|
|||
| ws WebSocketable | |||
|
|
|||
| pending sync.Map // pending requests | |||
| ctx context.Context | |||
There was a problem hiding this comment.
Will it impact the performance? Better to create a simple benchmark for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the Contextable interface for cdp.Client, preparing to introduce *goob.Observable: