Validation for python variable names #1195
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validation checks if string is a proper name for a python variable.
Fixes Or Enhances
Sometimes we may use our code to call external binaries, or even to construct what are effectively scripts.
Python is relatively loose, but it does enforce rules about variable names rather vehemently.
Specifically they must be generated by a specific grammar, and they must not be keywords[0].
The same restriction applies to ansible variables. So this validation may also be useful when one is constructing data structures intended to be used by ansible.
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers
[0] https://docs.python.org/3/reference/lexical_analysis.html#identifiers