Mux compat #2
Merged
Mux compat #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 1, 2024 11:43
Refactored the method of registering handlers in the routegroup operations, replacing `Handle` with `HandleFunc` for compatibility with mux. New `Handle` was added, accepting `http.Handler` param like the name suggests and the standard mux does. Also added `Handler` method redirecting to the mux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make
routegroup.Bundlemore compatible with the standard mux.Handlefunc to accepthttp.Handler, nothttp.HandlerFunclike it was before. This is a breaking changeHandlerFuncacceptingHandlerto locate the handler and the pattern that matches the requestThe result of this change is fill compatibility between
http.SeverMuxandroutegroup.Bundle