Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Panel autosizing fix #299

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

trunkmaster
Copy link
Member

@trunkmaster trunkmaster commented Oct 4, 2024

Fix autosizing of "Family" and "Typeface" browsers using different approach to NSView's default.

@fredkiefer
Copy link
Member

I am not sure whether all this is needed or if it could be sufficient to set the correct resizing attributes on the existing views. What is it that you want to achieve?

@trunkmaster
Copy link
Member Author

Sizing attributes are correct. Look at screenshots below, can you see the difference?

Initial panel size.
VirtualBox_Fedora 39_05_10_2024_02_39_46

Resized without my fix
VirtualBox_Fedora 39_05_10_2024_02_55_03

Resized with my fix
VirtualBox_Fedora 39_05_10_2024_02_43_26

@fredkiefer
Copy link
Member

Could you please try how the new resizing behaves when there is an accessoryView? This is not very common, we still need to support it.

@trunkmaster
Copy link
Member Author

My change doesn't affect accessoryView, only browsers: familyBrowser, typefaceBrowser and sizeBrowser which are inside bottomSplit view.

However I can add and test accessoryView. What results do you expect from me: screenshots or something else?

@fredkiefer
Copy link
Member

I don't need any proof, it is sufficient if you test it yourself.

@trunkmaster
Copy link
Member Author

Looks good.
VirtualBox_Fedora 39_09_10_2024_01_15_24
VirtualBox_Fedora 39_09_10_2024_01_17_21

@trunkmaster trunkmaster merged commit 40fc3ab into gnustep:master Oct 8, 2024
3 checks passed
@trunkmaster trunkmaster deleted the fontpanel-autosizing branch October 8, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants