Fix issues with storyboards and segues #206
Conversation
gcasa
force-pushed
the
NSPopover_issue168
branch
from
6f107d6 to
f59c7ed
Compare
| [_contentViewController loadView]; | ||
| view = [_contentViewController view]; | ||
| viewFrame = [view frame]; | ||
| window = [view window]; |
There was a problem hiding this comment.
I don't see where this new variable gets used.
There was a problem hiding this comment.
Right now things are in flux a bit. I will be moving a lot of things to NSDebugLog or removing them once I am done.
| @@ -294,8 +295,8 @@ - (void) showRelativeToRect: (NSRect)positioningRect | |||
| [_realPanel setFrame: windowFrame display: YES]; | |||
| [_realPanel makeKeyAndOrderFront:self]; | |||
|
|
|||
| NSDebugLog(@"Showing relative to in window %@",NSStringFromRect(positioningRect)); | |||
| NSDebugLog(@"Showing relative to in screen %@",NSStringFromRect(screenRect)); | |||
| NSLog(@"Showing relative to in window %@",NSStringFromRect(positioningRect)); | |||
There was a problem hiding this comment.
Is this a permanent change? If so, do we really want this log all the time?
There was a problem hiding this comment.
No, I will be taking it out before I finish.
| [po showRelativeToRect: rect | ||
| ofView: _popoverAnchorView | ||
| preferredEdge: _preferredEdge]; | ||
| NSLog(@"anchor view = %@", _popoverAnchorView); |
There was a problem hiding this comment.
Should rather be a NSDebugLLog
|
@fredkiefer I am working on some of the issues with segues as we had discussed months ago. The code that does the action for the segue is not generating (or decoding) that object properly so some of the data is not present. I am going through the logic and fixing issues. What's happening is that the popoverAnchorView isn't being decoded so the NSPopover is just appearing at a random place. There are also some other issues with that portion of the code. I would like to refactor things into separate classes for different kinds of segues, but I am not sure I am going to do that for this PR. |
|
OBE by refactor. No longer needed, so... closing. |
The purpose of this issue is to fix a number of remaining issues with NSPopover, principally the positioning issue and some issues with NSStoryboardSegue.