Skip to content

Commit

Permalink
FastPathAlloc: Skip if below clang 18.1.x (#304)
Browse files Browse the repository at this point in the history
* FastPathAlloc: Skip if below clang 18.1.x

* Remove AArch64 Android Emulator
  • Loading branch information
hmelder authored Oct 22, 2024
1 parent a9fa115 commit feaf007
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -265,22 +265,12 @@ jobs:
# Build each combination of OS and release/debug variants
os: [ ubuntu-20.04 ]
build-type: [ Release, Debug ]
# TODO(hugo): Add AArch64 configuration when GitHub AArch64 CI runners are available.
arch:
- name: x86_64
triple: x86_64-linux-android
emu-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
- name: arm64-v8a
triple: aarch64-linux-android
# Google broke ARM64 emulation on x86_64 hosts. A workaround is to overwrite the qemu machine type.
emu-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none -accel off -qemu -machine virt
api-level: [ 27, 33 ]
# Please note that:
# - arm64-v8a emulation on a x86_64 host currently is only possible up to API level 27 Oreo
# - armeabi-v7a is only supported up to API level 24
exclude:
- api-level: 33
arch:
name: arm64-v8a
# Don't abort runners if a single one fails
fail-fast: false
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion Test/FastPathAlloc.m
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#if __clang_major__ < 18
#if __clang_major__ < 18 || (__clang_major__ == 18 && __clang_minor__ < 1)
// Skip this test if clang is too old to support it.
int main(void)
{
Expand Down

0 comments on commit feaf007

Please sign in to comment.