Checkjira skip logs #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the CONFIG_ENCODING variable was set and the git configuration was empty, the get_config method would try to decode an undefined value. The fix also allowed us to avoid a conditional, which eliminated one level of nesting, which required a "no critic" directive to placate Perl::Critic. That's not necessary anymore.
gnustavo
force-pushed
the
checkjira-skip-logs
branch
from
af9f787 to
1e8f16c
Compare
|
Thinking about this some more, I do wonder if adding this directive is the best solution. There's a plugin for parsing logs already, so with my proposed 'OR' feature, that can be used instead of duplicating CheckLog functionality into individual plugins. Because I can see skip-logs being useful for other plugins as well, I don't think it's necessarily JIRA specific. I think a way where either CheckLog or CheckJira must match is cleaner. (The idea that is, not necessarily my implementation of it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the skip-logs directive.