feat: update gno dependency and add EstimateGas API function #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9
The gno's EstimateGas function takes a signed transition as a parameter. So it's preferable to only create a gnonative wrapper around it instead of making a new argument (aka estimateGas bool) on each kind of function (call, run, send).
So the flow would be that the dapp signs the transition with gnokey-mobile. After signing but before going back to the dapp, gnokey-mobile can show the estimate gas cost to the user, then gnokey-mobile returns also the gas estimation to the dapp which can also show it to the user as a dapp level confirmation before committing the transaction to the blockchain.