-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fmt #3578
Merged
Merged
chore: fmt #3578
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c7414be
chore: fmt
moul ca9c246
chore: fixup
moul 7b58a8e
Merge branch 'master' into dev/moul/fmt
moul b90a11a
Merge remote-tracking branch 'origin/master' into dev/moul/fmt
moul 08e023a
chore: fixup
moul 502b005
Merge remote-tracking branch 'origin/master' into dev/moul/fmt
moul 90dcbd8
Delete gnovm/pkg/gnolang/internal/softfloat/copy.sh
moul 4460fdb
Merge branch 'master' into dev/moul/fmt
moul 416ad55
Merge branch 'master' into dev/moul/fmt
moul e71e160
Merge remote-tracking branch 'origin/master' into dev/moul/fmt
moul 5991041
chore: fixup
moul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -50,9 +50,13 @@ install.gnokey:; go install ./cmd/gnokey | |||
.PHONY: dev.gnoweb generate.gnoweb | ||||
dev.gnoweb: | ||||
make -C ./pkg/gnoweb dev | ||||
generate.gnoweb: | ||||
|
||||
.PHONY: generate | ||||
generate: | ||||
go generate -x ./... | ||||
make -C ./pkg/gnoweb generate | ||||
|
||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Leftover?
Suggested change
|
||||
.PHONY: fclean | ||||
fclean: clean | ||||
rm -rf gnoland-data genesis.json | ||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
gnovm/pkg/gnolang/internal/softfloat/runtime_softfloat64_test.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will fail when being called by at least the following workflows (knowing that
main_template
forwards tobuild_template
):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really hate that we enforce random makefile directives within subfolders, just to follow a structure (prime example is
make lint
,make test
etc)