Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fmt #3578

Merged
merged 11 commits into from
Feb 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build_template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ jobs:
- name: Check generated files are up to date
working-directory: ${{ inputs.modulepath }}
run: |
go generate -x ./...
make generate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really hate that we enforce random makefile directives within subfolders, just to follow a structure (prime example is make lint, make test etc)


if [ "$(git status -s)" != "" ]; then
echo "command 'go generate' creates file that differ from git tree, please run 'go generate' and commit:"
git status -s
Expand Down
6 changes: 5 additions & 1 deletion gno.land/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,13 @@ install.gnokey:; go install ./cmd/gnokey
.PHONY: dev.gnoweb generate.gnoweb
dev.gnoweb:
make -C ./pkg/gnoweb dev
generate.gnoweb:

.PHONY: generate
generate:
go generate -x ./...
make -C ./pkg/gnoweb generate


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

Suggested change

.PHONY: fclean
fclean: clean
rm -rf gnoland-data genesis.json
Expand Down
2 changes: 1 addition & 1 deletion gnovm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ _test.filetest:;
# TODO: move _dev.stringer to go:generate instructions, simplify generate
# to just go generate.
.PHONY: generate
generate: _dev.stringer _dev.generate _dev.docs
generate: _dev.stringer _dev.generate _dev.docs fmt imports

.PHONY: _dev.docs
_dev.docs:
Expand Down
19 changes: 10 additions & 9 deletions gnovm/cmd/gno/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,16 @@ USAGE
gno <command> [arguments]

SUBCOMMANDS
bug start a bug report
clean remove generated and cached data
doc show documentation for package or symbol
env print gno environment information
fmt gnofmt (reformat) package sources
mod module maintenance
run run gno packages
test test packages
tool run specified gno tool
bug start a bug report
clean remove generated and cached data
doc show documentation for package or symbol
env print gno environment information
fmt gnofmt (reformat) package sources
mod module maintenance
run run gno packages
test test packages
tool run specified gno tool
version display installed gno version

```

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gnovm/tests/stdlibs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ available when testing gno code in `_test.gno` and `_filetest.gno` files.
Re-declarations of functions already existing override the definitions of the
normal stdlibs directory.

Adding imports that don't exist in the corresponding normal stdlib is undefined behavior
Adding imports that don't exist in the corresponding normal stdlib is undefined behavior
5 changes: 5 additions & 0 deletions tm2/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,8 @@ _test.pkg.others:; go test $(GOTEST_FLAGS) `go list ./pkg/... | grep -Ev 'pkg/(
_test.pkg.amino:; go test $(GOTEST_FLAGS) ./pkg/amino/...
_test.pkg.bft:; go test $(GOTEST_FLAGS) ./pkg/bft/...
_test.pkg.db:; go test $(GOTEST_FLAGS) ./pkg/db/... ./pkg/iavl/benchmarks/...

.PHONY: generate
generate:
go generate -x ./...
$(MAKE) fmt
12 changes: 4 additions & 8 deletions tm2/pkg/overflow/overflow_impl.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading