Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add account number / sequence as env in txtar #3477

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Jan 10, 2025

Pre-fetch the account number and sequence for both default and custom accounts created using the adduser and adduserfrom commands in txtar to make them available at runtime.
I've also converted the user environment variable to lowercase, as I feel this improves readability.

@gfanton gfanton self-assigned this Jan 10, 2025
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 10, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 10, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: gfanton/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 79.48718% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gno.land/pkg/integration/testscript_gnoland.go 69.23% 16 Missing and 8 partials ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: gfanton <[email protected]>
@zivkovicmilos zivkovicmilos self-requested a review January 10, 2025 13:12
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great UX bump 👏

return fmt.Errorf("unable create rpc client %q: %w", remote, err)
}

batch := cli.NewBatch()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants