Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-enable the portal loop CI #3474

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

zivkovicmilos
Copy link
Member

Description

This PR re-enables the portal loop "CI". I won't go into details on why this was needed in the first place, with the intention to not lose absolutely all credibility for our deployment and testing workflows

@zivkovicmilos zivkovicmilos added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 9, 2025
@zivkovicmilos zivkovicmilos requested a review from sw360cab January 9, 2025 23:23
@zivkovicmilos zivkovicmilos self-assigned this Jan 9, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 9, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • Determine if infra needs to be updated before merging (checked by @sw360cab)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
Determine if infra needs to be updated before merging

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: master
    └── 🟢 Or
        ├── 🔴 A changed file matches this pattern: Dockerfile
        ├── 🔴 A changed file matches this pattern: ^misc/deployments
        ├── 🔴 A changed file matches this pattern: ^misc/docker-
        ├── 🔴 A changed file matches this pattern: ^.github/workflows/releaser.*\.yml$
        └── 🟢 A changed file matches this pattern: ^.github/workflows/portal-loop\.yml$ (filename: .github/workflows/portal-loop.yml)

Can be checked by

  • team devops

@zivkovicmilos zivkovicmilos merged commit a57311b into master Jan 9, 2025
18 of 19 checks passed
@zivkovicmilos zivkovicmilos deleted the dev/zivkovicmilos/enable-pl-ci branch January 9, 2025 23:27
albttx pushed a commit that referenced this pull request Jan 10, 2025
## Description

This PR re-enables the portal loop "CI". I won't go into details on why
this was needed in the first place, with the intention to not lose
absolutely all credibility for our deployment and testing workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Development

Successfully merging this pull request may close these issues.

3 participants