-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boardsv2): initialize reposting #3469
feat(boardsv2): initialize reposting #3469
Conversation
🛠 PR Checks Summary🔴 Maintainers must be able to edit this pull request (more info) Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🔴 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
@jeronimoalbi can you please take a look 🙏 |
return "", nil | ||
} | ||
|
||
// TODO: figure out a way to decouple posts from a global storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TODO: figure out a way to decouple posts from a global storage.
I'm thinking we should eventually decouple it by having the render functions implemented as realm functions instead of Post
methods, otherwise repostBoardID
should instead be repostBoard
being of type *Board
.
cc @salmad3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a separate issue.
@x1unix when I tried reposting locally I noticed the repost helper link doesn't assign the |
A couple of things to consider.
|
When `replyID` is 0 it means the reply is the first thread reply.
@jeronimoalbi moving this to #3513 as GitHub borked the branch during merge update from a GUI |
See the original issue
Closes: #3227