Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boardsv2): initialize reposting #3469

Conversation

x1unix
Copy link
Contributor

@x1unix x1unix commented Jan 9, 2025

See the original issue

Closes: #3227

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 9, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 9, 2025

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check) (checked by @jeronimoalbi)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: gnostudio/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@x1unix x1unix marked this pull request as ready for review January 14, 2025 04:06
@x1unix
Copy link
Contributor Author

x1unix commented Jan 14, 2025

@jeronimoalbi can you please take a look 🙏

return "", nil
}

// TODO: figure out a way to decouple posts from a global storage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	// TODO: figure out a way to decouple posts from a global storage.

I'm thinking we should eventually decouple it by having the render functions implemented as realm functions instead of Post methods, otherwise repostBoardID should instead be repostBoard being of type *Board.

cc @salmad3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a separate issue.

@jeronimoalbi
Copy link
Member

@x1unix when I tried reposting locally I noticed the repost helper link doesn't assign the threadID to the input field. You can see that by clicking on the [repost] link.

@jeronimoalbi
Copy link
Member

A couple of things to consider.

  1. The rendered repost Markdown could be improved, we could use the layout that other platforms use for reposts as inspiration for a layout that makes more sense.

  2. I think the details being displayed after the body should refer to the repost instead of the source post. For example the [x] delete link would delete the source post instead of the repost.

Screenshot 2025-01-14 at 11 11 28
  1. We have to consider the repost as the main post in this context, where the source post is treated just as content (body) of the repost, being the repost the clickable title.
    Right now clicking will take users to the source post so at the moment is not possible to add comments for the repost.

  2. We should support reposting comments. We could implement it in a different issue. We could even maybe consider to implement it after the MVP if it makes sense, assuming we are good to go with only supporting reposting thread initially (cc @salmad3).

jeronimoalbi and others added 2 commits January 14, 2025 11:54
When `replyID` is 0 it means the reply is the first thread reply.
@x1unix
Copy link
Contributor Author

x1unix commented Jan 14, 2025

@jeronimoalbi moving this to #3513 as GitHub borked the branch during merge update from a GUI

@x1unix x1unix closed this Jan 14, 2025
@x1unix x1unix deleted the feat/3227-boardsv2-reposting branch January 15, 2025 17:23
jeronimoalbi pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants