-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boards2): add core flagging logic #3370
Conversation
🛠 PR Checks Summary🔴 Maintainers must be able to edit this pull request (more info) Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🔴 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
@jeronimoalbi does |
0890405
to
84e8f6e
Compare
No, only members of the board being checked |
@jeronimoalbi so both checks are necessary? If true - maybe |
I can't think of a case where both should be checked. Boards are independent communities which are independent of the governing body (permissions) assigned to the realm. In fact the realm can have a minimal impact on boards in very specific cases and only if the board creator opts in to be like that, like for example adding new members to a board in cases where access is lost, but overall each board is independent, so permissions for functionalities triggered by board members/users must be checked against that specific board instance. |
This can be risky, especially if board decide to post something NSFW or something that violates a law. I believe we should've some safeguard mechanism for that case. |
c90e8c7
to
32c8638
Compare
bdfde81
to
73d1973
Compare
@jeronimoalbi PR reopened in #3451 |
Closes #3146