Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards2): add core flagging logic #3370

Closed
wants to merge 11 commits into from

Conversation

x1unix
Copy link
Contributor

@x1unix x1unix commented Dec 19, 2024

Closes #3146

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 19, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 19, 2024

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: gnostudio/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 70.17544% with 289 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gno.land/pkg/integration/testscript_gnoland.go 68.76% 137 Missing and 32 partials ⚠️
gno.land/pkg/integration/process.go 69.53% 62 Missing and 23 partials ⚠️
gno.land/pkg/integration/pkgloader.go 65.68% 26 Missing and 9 partials ⚠️

📢 Thoughts on this report? Let us know!

@x1unix x1unix marked this pull request as ready for review December 19, 2024 22:30
@x1unix x1unix requested a review from jeronimoalbi December 20, 2024 21:27
@jeronimoalbi
Copy link
Member

@x1unix #3386 was merged so anytime you can bring the changes to this branch which have the assertHasBoardPermission() assertion needed for this PR

@x1unix
Copy link
Contributor Author

x1unix commented Dec 23, 2024

@jeronimoalbi does assertHasBoardPermission supports global superusers (someone who can manage a whole realm)?

@jeronimoalbi
Copy link
Member

@jeronimoalbi does assertHasBoardPermission supports global superusers (someone who can manage a whole realm)?

No, only members of the board being checked

@x1unix
Copy link
Contributor Author

x1unix commented Dec 23, 2024

@jeronimoalbi so both checks are necessary?

If true - maybe assertHasBoardPerm needs to be updated.

@jeronimoalbi
Copy link
Member

@jeronimoalbi so both checks are necessary?

If true - maybe assertHasBoardPerm needs to be updated.

I can't think of a case where both should be checked. Boards are independent communities which are independent of the governing body (permissions) assigned to the realm. In fact the realm can have a minimal impact on boards in very specific cases and only if the board creator opts in to be like that, like for example adding new members to a board in cases where access is lost, but overall each board is independent, so permissions for functionalities triggered by board members/users must be checked against that specific board instance.

@x1unix
Copy link
Contributor Author

x1unix commented Dec 23, 2024

@jeronimoalbi

Boards are independent communities which are independent of the governing body (permissions) assigned to the realm.

This can be risky, especially if board decide to post something NSFW or something that violates a law. I believe we should've some safeguard mechanism for that case.

@x1unix x1unix requested a review from jeronimoalbi January 6, 2025 18:54
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jan 6, 2025
@x1unix
Copy link
Contributor Author

x1unix commented Jan 7, 2025

@jeronimoalbi PR reopened in #3451

@x1unix x1unix closed this Jan 7, 2025
@x1unix x1unix deleted the feat/3146-flags branch January 7, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants