Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add p/moul/mdtable #3100

Merged
merged 2 commits into from
Nov 15, 2024
Merged

feat: add p/moul/mdtable #3100

merged 2 commits into from
Nov 15, 2024

Conversation

moul
Copy link
Member

@moul moul commented Nov 9, 2024

Can be useful for #3096.

@moul moul self-assigned this Nov 9, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 9, 2024
@moul moul requested a review from leohhhn November 9, 2024 10:06
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.77%. Comparing base (4f27a57) to head (f230fa3).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3100   +/-   ##
=======================================
  Coverage   63.77%   63.77%           
=======================================
  Files         548      548           
  Lines       78681    78681           
=======================================
  Hits        50180    50180           
- Misses      25117    25121    +4     
+ Partials     3384     3380    -4     
Flag Coverage Δ
contribs/gnodev 61.16% <ø> (+0.62%) ⬆️
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 73.62% <ø> (ø)
gnovm 67.92% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.40% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: moul <[email protected]>
@moul moul marked this pull request as ready for review November 12, 2024 12:45
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; however with the current look of the table in gnoweb, I think it's nicer to have a list of items as I did in my govdao rendering PR. This package is still welcome.

@moul moul merged commit a1812af into gnolang:master Nov 15, 2024
134 checks passed
@moul moul deleted the dev/moul/mdtable branch November 15, 2024 19:05
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
Can be useful for gnolang#3096.

---------

Signed-off-by: moul <[email protected]>
albttx pushed a commit that referenced this pull request Jan 10, 2025
Can be useful for #3096.

---------

Signed-off-by: moul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants