-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmd/gno/clean): allow to run gno clean -modcache
from anywhere + rename and use gnomod.ModCachePath
+ tmp GNOHOME
in main tests
#3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Norman Meier <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3083 +/- ##
==========================================
+ Coverage 63.33% 63.35% +0.01%
==========================================
Files 548 548
Lines 78680 78681 +1
==========================================
+ Hits 49835 49846 +11
+ Misses 25481 25473 -8
+ Partials 3364 3362 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Norman Meier <[email protected]>
n0izn0iz
force-pushed
the
refacto-clean-modcache
branch
from
November 7, 2024 00:33
951f6fa
to
76fa49c
Compare
Signed-off-by: Norman Meier <[email protected]>
jefft0
added
the
review/triage-pending
PRs opened by external contributors that are waiting for the 1st review
label
Nov 7, 2024
thehowl
approved these changes
Nov 7, 2024
thehowl
removed
the
review/triage-pending
PRs opened by external contributors that are waiting for the 1st review
label
Nov 7, 2024
Signed-off-by: Norman Meier <[email protected]>
n0izn0iz
changed the title
fix(cmd/gno/clean): allow to run
fix(cmd/gno/clean): allow to run Nov 7, 2024
gno clean -modcache
from anywhere + use GetGnoModPath
gno clean -modcache
from anywhere + rename and use gnomod.ModCachePath
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
n0izn0iz
changed the title
fix(cmd/gno/clean): allow to run
fix(cmd/gno/clean): allow to run Nov 8, 2024
gno clean -modcache
from anywhere + rename and use gnomod.ModCachePath
gno clean -modcache
from anywhere + rename and use gnomod.ModCachePath
+ tmp GNOHOME
in main tests
thehowl
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gno clean
, run the-modcache
case before checking for presence of agno.mod
to allow to rungno clean -modcache
from anywhere (like go)gno clean -modcache
to use thegnomod.GetGnoModPath
helper to get the modcache pathgnomod.GetGnoModPath
->gnomod.ModCachePath
gno
cmd tests by using a tmpGNOHOME
instead of the system oneContributors' checklist...
BREAKING CHANGE: xxx
message was included in the description