Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gnovm): save object when refCount changed #2992

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

fix(gnovm): save object when refCount changed #2992

wants to merge 26 commits into from

Conversation

omarsy
Copy link
Member

@omarsy omarsy commented Oct 21, 2024 •
edited
Loading

This PR a fix in the gnovm to ensure that objects are saved correctly when their reference count changes.

closes: #2266 #1543

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 21, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@omarsy omarsy mentioned this pull request Oct 21, 2024
Closed
@Kouteki Kouteki added this to the 🚀 Mainnet launch milestone Oct 22, 2024
@omarsy omarsy force-pushed the fix/2266 branch 2 times, most recently from 2dfe9bf to acf12f5 Compare October 26, 2024 22:27
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Oct 26, 2024
@omarsy omarsy force-pushed the fix/2266 branch 2 times, most recently from ed24417 to 2368fed Compare October 27, 2024 12:44
@omarsy omarsy force-pushed the fix/2266 branch 2 times, most recently from d81df2c to ff7e012 Compare October 27, 2024 15:40
@omarsy omarsy marked this pull request as ready for review October 27, 2024 19:24
@notJoon notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 28, 2024
@zxxma zxxma mentioned this pull request Nov 1, 2024
Open
@jefft0
Copy link
Contributor

jefft0 commented Nov 19, 2024

Hello @omarsy . There is a merge conflict with master in gno.land/pkg/sdk/vm/gas_test.go . Can you resolve it?

jefft0
jefft0 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main change is to one file gnovm/pkg/gnolang/realm.go . The rest of the changes are tests. All CI checks pass.

@jefft0 jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Nov 20, 2024
@jefft0
Copy link
Contributor

jefft0 commented Nov 20, 2024

Removed the review/triage-pending label because jefft0 approved. Ready for core devs to review if the change is technically correct.

ltzmaxwell
ltzmaxwell reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ltzmaxwell ltzmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just start looking.

gnovm/pkg/gnolang/realm.go Show resolved Hide resolved
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Nov 28, 2024
@omarsy
Copy link
Member Author

omarsy commented Dec 4, 2024

@omarsy Can you please check the CI? 🙏

Done ^^

ltzmaxwell
ltzmaxwell approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@ltzmaxwell ltzmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

gnovm/tests/files/zrealm17.gno Outdated Show resolved Hide resolved
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Dec 7, 2024
@Gno2D2 Gno2D2 requested review from a team December 7, 2024 22:10
@omarsy omarsy removed request for a team December 7, 2024 22:13
thehowl
thehowl reviewed Dec 7, 2024
View reviewed changes
examples/gno.land/r/demo/boards/z_4_filetest.gno Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's going on here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is caused by the change of the reference count of the time package.
It occurs because the time.Time struct is a field of the Board object. When the Board object is referenced, it indirectly causes the reference count of the time package to change, as the time.Time struct is part of the Board

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhhh, should package values be persisted like this? I don't think so?

In the very least, we shouldn't have a 15k line long file with the entire PackageValue of the time package, but I'm thinking whether we need to add an exception to saving package values?

Copy link
Member Author

@omarsy omarsy Dec 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should avoid to log Block operation like this 7438f8a#diff-152fa445ed649a7f12eb067c6a67f7c6cb98c3242e23da200744b851aaeb3b20R522 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thehowl
Are you alright with the change, or should @omarsy wait on the merge?

@omarsy omarsy requested a review from thehowl December 20, 2024 20:01
@zivkovicmilos
Copy link
Member

@omarsy

Can you please check the CI? 🙏

@omarsy
Copy link
Member Author

omarsy commented Jan 6, 2025

@omarsy

Can you please check the CI? 🙏

Done ! ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos left review comments

@ltzmaxwell ltzmaxwell ltzmaxwell approved these changes

@jefft0 jefft0 jefft0 approved these changes

@thehowl thehowl Awaiting requested review from thehowl

Assignees

@omarsy omarsy

Labels
in focus Core team is prioritizing this work 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
💪 Bounties & Worx
Status: In Progress
🧙‍♂️gno.land core team
Status: In Review
Milestone
🚀 Mainnet beta launch
Development

Successfully merging this pull request may close these issues.

[gnovm/avl] Removing keys from AVL trees does not work
8 participants
@omarsy @jefft0 @Gno2D2 @zivkovicmilos @thehowl @ltzmaxwell @notJoon @Kouteki