-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnovm): align Gno constant handling with Go specifications #2828
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
c9b02d2
to
f49c088
Compare
355d799
to
e9a9be7
Compare
@omarsy , can you fix the lint-pr-title CI check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approve this. @omarsy thank you for fixing this.
cc: @thehowl to finalize this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the rest is good; some better documentation is appreciated but you can send it in another PR ;)
Related Issues:
Closes #2628
This PR aims to align Gno's constant handling with the Go specification regarding constant expressions (see Go Specification on Constants).
Primitive Type Requirement
Function Calls Disallowed
Only built-in functions should be allowed.
Constant Operands Requirement
Constant expressions may contain only constant operands and are evaluated at compile time.
Type Assertion Forbidden
Index Expression Forbidden
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description