Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial patch version for FoundryVTT 0.8.6 and newer #50

Open
wants to merge 265 commits into
base: master
Choose a base branch
from

Conversation

p4535992
Copy link

NOTE: This is not operational version yet, need more test.
Hi everyone, I started with the help of Szefo09 a patching version for this module for the versions of FoundryVTT 0.8.6 and newer.
Unfortunately I got a little caught up in other things. If anyone wanted to help me especially with the tests I never find the time for, I would be really happy.

Marco Tenti and others added 2 commits July 1, 2021 15:41
@gludington
Copy link
Owner

Thank you very much for this, @p4535992 . Clearly, real life has kept me far away from being able to touch this project or even Foundry for long time - i have not even been able to install v0.8.x anywhere. According to your note, do you have a set of ideas in mind that require further shakedown?

@p4535992
Copy link
Author

p4535992 commented Jul 26, 2021

Hi gludington (happy to see you again) look I humbly updated the project and integrated the foundryvtt-types library most of the work (if not completely) was done by szefo09. I also couldn't find the time to test it properly (some feedback from the community has been there). A little bit of everything would have to be redefined to integrate the new "Document" class of foundryvtt version 0.8.X. For some details of what was done in the fork you can find here the details changelog. Greetings.

Some cleaning of some functions, implement a workaround for levels compatibility (Some testing pending), fix of pf2e sightlayer constructor, implement debouncing on pf2e
@jllansford
Copy link

I just want to say I love this module and I do hope to get a fully supported version working soon. If you guys need help testing I'd happily assist. With that said as of right now I can't seem to get this branch to work at all in my game, though it might be some incapability with other mods. I know it doesn't play well with the levels mod so I made sure to turn that off.

@p4535992
Copy link
Author

I just want to say I love this module and I do hope to get a fully supported version working soon. If you guys need help testing I'd happily assist. With that said as of right now I can't seem to get this branch to work at all in my game, though it might be some incapability with other mods. I know it doesn't play well with the levels mod so I made sure to turn that off.

Made a new patch version 0.2.8 , I don't guarantee anything, but you can test for it

@ravingdragoon
Copy link

Oddly, for me, nothing works after version 0.2.1. I am running Foundry 0.8.9 on Chrome Version 92.0.4515.159 (Official Build) (64-bit) and took it down to just Conditional Visibility and its dependencies. After 0.2.1 t seems to recognize existing stealth/hidden states, but does not recognize newly added ones.

@p4535992
Copy link
Author

p4535992 commented Sep 1, 2021

Oddly, for me, nothing works after version 0.2.1. I am running Foundry 0.8.9 on Chrome Version 92.0.4515.159 (Official Build) (64-bit) and took it down to just Conditional Visibility and its dependencies. After 0.2.1 t seems to recognize existing stealth/hidden states, but does not recognize newly added ones.

Can you give me more information? Are there any exceptions on the web console? Can you give me a "step to step" description to replicate the problem?

Marco Tenti and others added 4 commits September 6, 2021 15:21
- Cleaning of some functions and use of the constants added by Marco Tenti
- Remove deprecations for v9 of foundry
- Expand in the workaround for levels
- Fixing hidden status and vision for linked actors and non representing tokens
- Added a variable to the tokens for future usage in compatibility layers with other modules
Cleaning, formatting and bug corrections
@p4535992
Copy link
Author

hey @gludington , it seems that @Teshynil has made a stable version of the fork, see if you want to test it and possibly try to merge this PR.

@ravingdragoon
Copy link

ravingdragoon commented Sep 19, 2021

@p4535992 sorry it took so long. After troubleshooting it seems that what is not working properly for me after the 0.2.9 from @Teshynil is the Auto-Hide on Stealth feature for DnD 5e and the show/request stealth roll when applying Hidden through the status effects. I do not get any errors in the console when I try to roll stealth, but I do get the following warning when I use the feature through the Status Effects menu instead of using a Stealth roll.

dae | Dae macro on
Actor5e {overrides: {…}, _preparationWarnings: Array(0), armor: null, shield: null, _classes: {…}, …}
apps: {}
armor: null
getOwnedItem: ƒ (id)
labels: {creatureType: 'Humanoid (Elf)'}
longRest: async ƒ ()
overrides: {data: {…}, flags: {…}}
shield: null
shortRest: async ƒ ()
_classes: {}
_lastWildcard: null
_preparationWarnings: []
_sheet: null
tokenImages: (2) ['https://assets.forge-vtt.com/604155e2aca674c278836…or-cos/characters/104-Rahadin/RahadinAction.png', 'https://assets.forge-vtt.com/604155e2aca674c278836…ules/cor-cos/characters/104-_Rahadin/avatar.webp']
applyActiveEffects: (...)
applyDamage: (...)
classes: (...)
collection: (...)
collectionName: (...)
compendium: (...)
data: ActorData {_id: 'M2NlY2IzOWI5Nzhi', name: 'Rahadin', type: 'npc', img: 'https://assets.forge-vtt.com/604155e2aca674c278836…rse-of-strahd/characters/139_-_Rahadin/avatar.png', data: {…}, …}
documentName: (...)
effects: (...)
entity: (...)
folder: (...)
getRollData: (...)
hasPlayerOwner: (...)
id: (...)
img: (...)
isEmbedded: (...)
isOwner: (...)
isPolymorphed: (...)
isToken: (...)
itemTypes: (...)
items: (...)
limited: (...)
link: (...)
name: (...)
owner: (...)
pack: null
parent: null
permission: (...)
prepareData: (...)
rollAbilitySave: (...)
rollAbilityTest: (...)
rollDeathSave: (...)
rollSkill: (...)
sheet: (...)
temporaryEffects: (...)
toCompendium: (...)
token: (...)
type: (...)
uuid: (...)
visible: (...)
_data: (...)
_id: (...)
[[Prototype]]: Actor
[ActiveEffectData]
0: ActiveEffectData {_id: 'qkpo38nmr3ad786g', changes: Array(0), disabled: false, duration: EffectDurationData, icon: 'modules/conditional-visibility/icons/newspaper.svg', …}
length: 1
[[Prototype]]: Array(0)
{}
[[Prototype]]: Object
[[Prototype]]: Object
warn @ dae.js:24
daeMacro @ dae.js:1069
_preCreateActiveEffect @ dae.js:860
🎁call_wrapper @ libWrapper-wrapper.js:576
🎁CONFIG.ActiveEffect.documentClass.prototype._preCreate#0 @ libWrapper-wrapper.js:164
_preCreateDocumentArray @ foundry.js:8669
_createEmbeddedDocuments @ foundry.js:8629
create @ backend.mjs:95
async function (async)
create @ backend.mjs:93
createDocuments @ document.mjs:332
create @ document.mjs:431
update @ api.js:386
changeIconCounter @ keybinds.js:215
onEffectClick @ keybinds.js:115
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2

@p4535992
Copy link
Author

@ravingdragoon can you try version 0.2.10 ? i made some small fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants