Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused appliance massive actions #18757

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

cconard96
Copy link
Contributor

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

These two actions are never added to any itemtypes because Appliance::getMassiveActionsForItemtype isn't called from anywhere. Instead, CommonDBTM already adds the "Associate to an appliance" action to the itemtypes that can be linked to an Appliance.

Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if unlikely, it might be used by some plugin.
Maybe we should add it to the changelog ?

@trasher trasher merged commit 3f74e92 into glpi-project:main Jan 23, 2025
9 checks passed
@cedric-anne cedric-anne added this to the 11.0.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants