-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream only specific responses #18348
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break the handling of debug error messages by the new API.
See DebugResponseMiddleware.php.
This handling would have to be adjusted.
I reverted the changes made on the HLAPI. It will not be impacted by the current changes because it has its own controller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blank page (without errors): /front/ruledictionnarysoftware.php?replay_rule=replay_rule
I put this PR back to draft. In GLPI 11.0, the progress bar display is broken. I am not able to understand what is the issue behind this. Anyway, using With #18296, we will add a new progress bar system that we will have to use in replacement of the current system. Once it will be done, the current PR will be ready to be merged. I tested the |
8f2e565
to
e4f9603
Compare
- fix cron system in web context - permit legacy scripts to return their own `Response` objects - trigger error when content is flushed by a legacy script - deprecate `Html::glpi_flush()` - deprecate the legacy progress bar system
e4f9603
to
cb6a3aa
Compare
Checklist before requesting a review
Description
The proposed changes should permit to limit the usage of streamed responses to the endpoints that actually really require it.
These changes will also permit:
flush()
/ob_flush()
/ob_clean()
/ob_end_clean()
operations (I added a warning for this);exit()
/die()
instruction is used.Whitespace changes should be ignored for the review. Many changes are just related to encapsulation of some scripts in a streamed response object.