fix rights in computer tabs - see #3218

glpi-project · Nov 29, 2017 · 1c6c9dc · 1c6c9dc
1 parent 92f9835
commit 1c6c9dc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/inc/computerantivirus.class.php b/inc/computerantivirus.class.php
@@ -188,7 +188,7 @@ static function getSearchOptionsToAdd() {
    function showForm($ID, $options=array()) {
       global $CFG_GLPI;
 
-      if (!Session::haveRight("computer", UPDATE)) {
+      if (!Session::haveRight("computer", READ)) {
          return false;
       }
 
@@ -262,6 +262,7 @@ function showForm($ID, $options=array()) {
       echo "<td colspan='2'></td>";
       echo "</tr>";
 
+      $options['canedit'] = Session::haveRight("computer", UPDATE);
       $this->showFormButtons($options);
 
       return true;

diff --git a/inc/computerdisk.class.php b/inc/computerdisk.class.php
@@ -102,7 +102,7 @@ function defineTabs($options=array()) {
       $ong = array();
       $this->addDefaultFormTab($ong);
       $this->addStandardTab('Log', $ong, $options);
-      
+
       return $ong;
    }
 
@@ -144,7 +144,7 @@ static function cloneComputer ($oldid, $newid) {
    function showForm($ID, $options=array()) {
       global $CFG_GLPI;
 
-      if (!Session::haveRight("computer", UPDATE)) {
+      if (!Session::haveRight("computer", READ)) {
          return false;
       }
 
@@ -209,6 +209,7 @@ function showForm($ID, $options=array()) {
       Html::autocompletionTextField($this, "freesize");
       echo "&nbsp;".__('Mio')."</td></tr>";
 
+      $options['canedit'] = Session::haveRight("computer", UPDATE);
       $this->showFormButtons($options);
 
       return true;