Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document auto-login disabling #1127

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Document auto-login disabling #1127

merged 1 commit into from
Jan 14, 2025

Conversation

derek-globus
Copy link
Contributor

@derek-globus derek-globus commented Jan 14, 2025 •
edited by github-actions bot
Loading

  • Documentation didn't explain what happened if GlobusAppConfig.token_validation_error_handler was set to None (or explain that it could be set to None). Added that explanation.

📚 Documentation preview 📚: https://globus-sdk-python--1127.org.readthedocs.build/en/1127/

sirosen
sirosen approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those infix type declarations in ivar blocks for Sphinx might not be needed, since sphinx can read annotations. But let me look at fixing that after this merges, so that we can have the doc content itself updated.

@derek-globus derek-globus merged commit 1a33571 into globus:main Jan 14, 2025
8 checks passed
@sirosen
Copy link
Member

sirosen commented Jan 14, 2025

FWIW: I was wrong. autodoc_typehints doesn't support loading the annotations off of dataclass fields.
I'd like to get that working, but it probably requires a custom plugin. :(

@derek-globus derek-globus deleted the fix-app-config-doc-ivar branch January 14, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirosen sirosen sirosen approved these changes

@aaschaer aaschaer Awaiting requested review from aaschaer aaschaer is a code owner

@ada-globus ada-globus Awaiting requested review from ada-globus ada-globus is a code owner

@kurtmckee kurtmckee Awaiting requested review from kurtmckee kurtmckee is a code owner

@m1yag1 m1yag1 Awaiting requested review from m1yag1 m1yag1 is a code owner

@MaxTueckeGlobus MaxTueckeGlobus Awaiting requested review from MaxTueckeGlobus MaxTueckeGlobus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derek-globus @sirosen