add support for filter_entity_type on transfer client endpoint search #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjhinton-globus
requested review from
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
m1yag1,
MaxTueckeGlobus and
sirosen
as code owners
pjhinton-globus
force-pushed
the
pjhinton/sc-37389-transfer-client-collection-search-filter-entity-type
branch
from
a1df63c to
96d7880
Compare
sirosen
requested changes
Nov 26, 2024
....d/20241112_220331_pjhinton_sc_37389_trasfer_client_collection_search_filter_entity_type.rst
Outdated
Show resolved
Hide resolved
....d/20241112_220331_pjhinton_sc_37389_trasfer_client_collection_search_filter_entity_type.rst
Outdated
Show resolved
Hide resolved
....d/20241112_220331_pjhinton_sc_37389_trasfer_client_collection_search_filter_entity_type.rst
Outdated
Show resolved
Hide resolved
Added a new keyword argument to TransferClient.endpoint_search() that supports filtering by the collection entity type. Updated filter_non_functional argument to indicate its mutual exclusivity with filter_entity_type. refs sc-37389
pjhinton-globus
force-pushed
the
pjhinton/sc-37389-transfer-client-collection-search-filter-entity-type
branch
from
96d7880 to
794c708
Compare
Changes implemented per review from @sirosen. * Uncommented out header lines for scriv and removed lines not pertinent to change. * Updated annotation for filter_entity_type to use Literal[] with list of five recognized entity types as the API only accepts a single entity type as a value. * Updated documentation for filter_entity_type be more explicit that it filters on only one type. That is, you can't combine them into a comma-delimited list.
sirosen
requested changes
Dec 3, 2024
....d/20241112_220331_pjhinton_sc_37389_trasfer_client_collection_search_filter_entity_type.rst
Outdated
Show resolved
Hide resolved
Per @sirosen guidance. Fixing my RST noob error by doubling backticks on inline code.
sirosen
approved these changes
Dec 3, 2024
pjhinton-globus
deleted the
pjhinton/sc-37389-transfer-client-collection-search-filter-entity-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new keyword argument to TransferClient.endpoint_search() that supports filtering by the collection entity type. Updated filter_non_functional argument to indicate its mutual exclusivity with filter_entity_type.
Once this has passed through review, a separate PR will be opened for the CLI that adds a
--filter-entity-typeoption toglobus endpoint search.refs sc-37389
📚 Documentation preview 📚: https://globus-sdk-python--1109.org.readthedocs.build/en/1109/