Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete test for MEP config #1765

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Remove obsolete test for MEP config #1765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions compute_endpoint/tests/unit/test_cli_behavior.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,23 +583,6 @@ def test_multi_user_config_enforces_no_engine(mock_command_ensure, ep_name, run_
assert "engine\n" in rc.stderr, (rc.stdout, rc.stderr)


def test_multi_user_instantiates_no_engine(mock_command_ensure, ep_name, run_line):
"""different from *enforces* no engine because of historical Config()
implementation that default instantiates an Executor, if it's not specified"""
ep_dir = mock_command_ensure.endpoint_config_dir / ep_name
ep_dir.mkdir(parents=True)
data = {"config": ""}

config = {"multi_user": True}
data["config"] = yaml.safe_dump(config)

to_patch = "globus_compute_endpoint.endpoint.config.config.GlobusComputeEngine"
with mock.patch(to_patch) as mock_gce_cls:
rc = run_line(f"start {ep_name}", stdin=json.dumps(data), assert_exit_code=1)

assert not mock_gce_cls.called, (rc.stdout, rc.stderr)


@pytest.mark.parametrize("use_uuid", (True, False))
@mock.patch(f"{_MOCK_BASE}get_config")
@mock.patch(f"{_MOCK_BASE}Endpoint.get_endpoint_id")
Expand Down
Loading