Convert test class to threading #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
added
the
no-news-is-good-news
khk-globus
requested review from
yadudoc,
rjmello,
LeiGlobus and
chris-janidlo
chris-janidlo
approved these changes
Jan 16, 2025
There's no need to create an external process to run the AMQP test class; in
fact, doing so has hidden a couple of subtle pika interaction bugs.
Consequently, though the motivating change in this commit is:
- multiprocessing
+ threading/queue.SimpleQueue
there are also some fixes in `test/.../result_queue_subscriber` around the
proper shutdown procedure of the `pika.SelectConnection`: don't stop the loop
prematurely, and close all resources.
khk-globus
force-pushed
the
simplify_test_support_to_thread
branch
from
3852c03 to
a8245b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to create an external process to run the AMQP test class; in fact, doing so has hidden a couple of subtle pika interaction bugs. Consequently, though the motivating change in this commit is:
there are also some fixes in
test/.../result_queue_subscriberaround the proper shutdown procedure of thepika.SelectConnection: don't stop the loop prematurely, and close all resources.Type of change