Check before test ioloop close #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
added
the
no-news-is-good-news
khk-globus
requested review from
yadudoc,
chris-janidlo,
rjmello and
LeiGlobus
khk-globus
force-pushed
the
close_test_pika_ioloops
branch
3 times, most recently
from
61415e5 to
8218488
Compare
- remove an unwarranted test `reconnect()` (makes flow much simpler to verify) - don't forget to remove reference to connection so it can be GC'd - remove redundant shutdown requests, given fixtures - fix test to let ioloop know that connection is closing, allows for a cleaner shutdown in the ioloop internals.
khk-globus
force-pushed
the
close_test_pika_ioloops
branch
from
8218488 to
6e15241
Compare
LeiGlobus
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reconnect()(makes flow much simpler to verify)Type of change