Restrict serializers #1760
Merged
Restrict serializers #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-janidlo
requested review from
yadudoc,
ryanchard,
rjmello,
joshbryan-globus,
khk-globus and
LeiGlobus
khk-globus
reviewed
Jan 16, 2025
chris-janidlo
force-pushed
the
restrict-serializers
branch
3 times, most recently
from
4706581 to
9113665
Compare
rjmello
reviewed
Jan 22, 2025
compute_endpoint/globus_compute_endpoint/engines/globus_compute.py
Outdated
Show resolved
Hide resolved
chris-janidlo
force-pushed
the
restrict-serializers
branch
6 times, most recently
from
8a8188d to
a0da344
Compare
This is in order to enable non-test code to use the property.
Also move some errors to SerdeErrors instead of SerializationError / DeserializationError, if those errors happen before anything is actually serialized or deserialized; and make the ComputeSerializer enforce that selectable serialization strategies are properly for_code or not.
chris-janidlo
force-pushed
the
restrict-serializers
branch
from
a0da344 to
267a14b
Compare
|
(rebased on main) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds functionality to the
ComputeSerializerto restrict what strategies can be used to deserialize a payload, and exposes that functionality to engines.The first 3 commits are mostly cleanup. The meat of the changes is in the second to last commit, and the last commit is just about surfacing this functionality to endpoint configs.
[sc-35784]
Type of change